[Dynamic Dashboard] Orders card empty state #11536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11536 +/- ##
============================================
- Coverage 40.24% 40.22% -0.02%
Complexity 5202 5202
============================================
Files 1089 1089
Lines 63462 63487 +25
Branches 8711 8718 +7
============================================
Hits 25539 25539
- Misses 35619 35644 +25
Partials 2304 2304 ☔ View full report in Codecov by Sentry. |
Closed
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/orders/DashboardOrdersCard.kt
hichamboushaba
approved these changes
May 21, 2024
There was a problem hiding this comment.
Nice work @0nko, it works well.
I won't merge to give you a chance to visit this discussion p1716276731997339-slack-C03L1NF1EA3 and decide if we should align with iOS on this or not.
|
Thanks Hicham, I think we're aligned 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11461. Adds the empty state UI to orders card.
To test: